Improved CI - check fmt #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsorr
force-pushed
the
feature/validate-scalafmt
branch
3 times, most recently
from
0761e35 to
934d1fe
Compare
SemyonSinchenko
approved these changes
Sep 11, 2024
|
@SemyonSinchenko @zeotuan I'm thinking of moving the benchmarking to the CI quality pipeline to run it only once and in parallel to speed up testing. |
Changed the scala setup plugin to a maintained action. Pipeline to check if the format is correct. Added a cache to improve the speed in CI runs. Updated checkout action to the latest version.
code format
alfonsorr
force-pushed
the
feature/validate-scalafmt
branch
from
ebcd845 to
e64eca8
Compare
Sound good! Do you think we should still have benchmarks running for different version? |
|
Maybe have it for only one in the pr's or when merged and maybe in the release flow test against all of them. Not sure if testing against multiple versions will make a difference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the scala setup plugin to a maintained action. Pipeline to check if the format is correct.
Added a cache to improve the speed in CI runs.
Updated checkout action to the latest version.