Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

434 add validation to observations #436

Merged
merged 10 commits into from
Apr 6, 2024
Merged

434 add validation to observations #436

merged 10 commits into from
Apr 6, 2024

Conversation

wsobel
Copy link
Member

@wsobel wsobel commented Apr 6, 2024

  • added deprecated property when schema version is later than deprecated controlled vocab
    • Can be tested using Execution PROGRAM_OPTIONAL_STOP
    • Added more tests for deprecation
    • Added documentation
  • Added tests for header validation flag in agent test
  • Consider tables and datasets valid–do not validate

@wsobel wsobel requested review from simonyg and tbm0115 April 6, 2024 21:28
@wsobel wsobel assigned wsobel and unassigned tbm0115 and simonyg Apr 6, 2024
@wsobel wsobel merged commit 053cf42 into main-dev Apr 6, 2024
7 checks passed
@wsobel wsobel deleted the 434_add_validation_to_observations branch April 29, 2024 02:27
@wsobel wsobel added this to the Version 2.5 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonyg simonyg simonyg approved these changes

@tbm0115 tbm0115 Awaiting requested review from tbm0115

Assignees

@wsobel wsobel

Labels
None yet
Projects
None yet
Milestone
Version 2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@wsobel @simonyg @tbm0115