[Slider] Change Slider.Output to Slider.Value and add format prop
#990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
the
component: slider
1 task
Netlify deploy preview |
mj12albert
force-pushed
the
feat/format-slider
branch
2 times, most recently
from
f04ddaa to
2f57fe2
Compare
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
feat/format-slider
branch
from
80f8ce2 to
af34261
Compare
github-actions
bot
removed
the
PR: out-of-date
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
mj12albert
force-pushed
the
feat/format-slider
branch
from
af34261 to
8357e0c
Compare
github-actions
bot
added
PR: out-of-date
mj12albert
force-pushed
the
feat/format-slider
branch
2 times, most recently
from
cae92e2 to
72dba3a
Compare
github-actions
bot
added
the
PR: out-of-date
mnajdova
reviewed
Dec 11, 2024
Comment on lines
11
to
17
| * Demos: | ||
| * | ||
| * * [Slider](https://base-ui.com/components/react-slider/) | ||
| * | ||
| * API: | ||
| * | ||
| * * [SliderValue API](https://base-ui.com/components/react-slider/#api-reference-SliderValue) |
There was a problem hiding this comment.
This shouldn't be here, it's using the old format.
mj12albert
force-pushed
the
feat/format-slider
branch
from
72dba3a to
625312d
Compare
github-actions
bot
removed
the
PR: out-of-date
mj12albert
commented
Dec 12, 2024
| @@ -1,6 +1,9 @@ | |||
| { | |||
There was a problem hiding this comment.
@vladmoroz The *.Value components also support children as a function (with some props) for formatting: https://github.com/mui/base-ui/blob/master/docs/data/components/select/select.mdx?plain=1#L179-L183
Should we add them to docs/reference/overrides to show them in the props table as well?
There was a problem hiding this comment.
Should we add them to docs/reference/overrides to show them in the props table as well?
Yes please!
mj12albert
force-pushed
the
feat/format-slider
branch
from
e826a63 to
dfa2411
Compare
mj12albert
force-pushed
the
feat/format-slider
branch
from
dfa2411 to
a452999
Compare
1 task
vladmoroz
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #961
Slider.Valuematches the rendering API ofSelect.ValueformatmatchesNumberFieldand does not take an array for range sliders, as it would makearia-valuetextfor range sliders inconsistent (comment)I have followed (at least) the PR section of the contributing guide.