Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Ensure clock is restored when using clock.withFakeTimers #43724

Closed

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Sep 12, 2024

A different approach in an effort to address: mui/mui-x#14583

@LukasTy LukasTy added test scope: code-infra Specific to the core-infra product labels Sep 12, 2024
@LukasTy LukasTy self-assigned this Sep 12, 2024
@mui-bot
Copy link

mui-bot commented Sep 12, 2024

Netlify deploy preview

https://deploy-preview-43724--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0358be1

@LukasTy LukasTy changed the title [code-infra] Restore clock is restored when using clock.withFakeTimers [code-infra] Ensure clock is restored when using clock.withFakeTimers Sep 12, 2024
@LukasTy
Copy link
Member Author

LukasTy commented Sep 13, 2024

Closing as restore seems to be already called and nothing I thought of alleviates the test flakiness. 🙈

@LukasTy LukasTy closed this Sep 13, 2024
@LukasTy LukasTy deleted the attempt-to-fix-timer-mocking-flakiness branch September 13, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants