Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Ensure clock is restored when using clock.withFakeTimers #43724

Closed
wants to merge 4 commits into from
Closed

[code-infra] Ensure clock is restored when using clock.withFakeTimers #43724

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de384fb
[code-infra] Restore `clock` is restored when using `clock.withFakeTi…
LukasTy Sep 12, 2024
7b172fb
Test if block gets called
LukasTy Sep 12, 2024
91ee9d1
Try direct `clock.restore` call
LukasTy Sep 12, 2024
0358be1
Check `createClock` hooks
LukasTy Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages-internal/test-utils/src/createRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@ function createClock(defaultMode: 'fake' | 'real', config: ClockConfig): Clock {

beforeEach(() => {
if (mode === 'fake') {
console.log('Initializing fake timers in `beforeEach` hook.');
clock = useFakeTimers({
now: config,
// useIsFocusVisible schedules a global timer that needs to persist regardless of whether components are mounted or not.
Expand All @@ -389,6 +390,7 @@ function createClock(defaultMode: 'fake' | 'real', config: ClockConfig): Clock {
});

afterEach(() => {
console.log('Restoring fake timers in `afterEach` hook.');
clock?.restore();
clock = null;
});
Expand Down Expand Up @@ -434,6 +436,7 @@ function createClock(defaultMode: 'fake' | 'real', config: ClockConfig): Clock {

after(() => {
mode = defaultMode;
clock?.restore();
});
},
restore() {
Expand Down