[DataGrid] Refactor GridMenu prop onClickAway to onClose
#10411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
the
component: data grid
romgrk
changed the title
GridMenu prop onClickAwayGridMenu prop onClickAway to onClose
Netlify deploy previewNetlify deploy preview: https://deploy-preview-10411--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
romgrk
force-pushed
the
refactor-grid-menu-close
branch
from
42f8d8e to
f70fb0a
Compare
cherniavskii
approved these changes
Sep 21, 2023
…to refactor-grid-menu-close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed all our usages of
GridMenuuse the same logic, so it's easier to centralize.Following an exploration done for #10241 but unrelated.