[tree view] Introduce a Tree View Store to clean the internals #20051
+4,505
−5,379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
type: enhancement
|
Deploy preview: https://deploy-preview-20051--material-ui-x.netlify.app/ Updated pages:
Bundle size report
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
flaviendelangle
force-pushed
the
tree-view-store
branch
from
4e145d8 to
9887252
Compare
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14228
Closes #19426
Extracted PRs
TreeItemIdtype instead of raw string #20233apiRef#20235In this PR:
storeobject is created once on mount with all its method. There is no code run on every render to update its methods.contextValue.wrapRootproperty have been replaced by manual JSX in the various Tree View components.useMemoinstead of being listed by each plugin.Differences with the Scheduler stores
The product methods are stored in plugin instead of being defined by the store
On the Scheduler, we call methods like
store.setVisibleResources. For the Tree View, the equivalent would bestore.resources.setVisibleResources.This is because the main store create several sub-classes for each main feature (focus, keyboard navigation, expansion, ...) that expose there own methods. This make the codebase a lot more scalable.