Fixed #3363 - added resourceName as global variable
#3530
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both you and Nico submitted a fixed PR at the exact same time (lol) Code reviews and (self-)feedback should determine which of the 2 PR's is ideal, and to save us time, also please add details on what the problem was and how you fixed it; there's no specific "fix" commit. |
|
This pull request does not restore the intended functionality of the original pull request, there are now two open and mine includes the rest. |
|
@Nico8340 You are the original owner of the PR. You may be the honoured one to fix it :) |
I'm okay with it, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.