-
-
Notifications
You must be signed in to change notification settings - Fork 488
GetResourceName default parameter and Global variable #3531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Both you and Tracer submitted a fixed PR at the exact same time (lol) Code reviews and (self-)feedback should determine which of the 2 PR's is ideal, and to save us time, also please add details on what the problem was and how you fixed it; there's no specific "fix" commit. |
This pull request contains the option to omit the parameter of the cc @Dutchman101 |
The other pull request was closed by Tracer's own decision, so this is the only one left. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Additions
getResourceName
function, which is based on the current resourceresourceName
, which is based on the current resourceAntecedent
This is a continuation of the previous pull request (#3363) which fixed the previously mentioned map editor issues.
Thus this pull request closes #3527
Example