Handle consumed balance #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
commented
Nov 27, 2024
| senderBalance := item.senderState.Balance | ||
|
|
||
| willFeeExceedBalance := futureAccumulatedFee.Cmp(senderBalance) > 0 | ||
| willFeeExceedBalance := futureConsumedBalance.Cmp(senderBalance) > 0 |
There was a problem hiding this comment.
We don't detect invalid transactions. We always assume that the value to be transferred is actually transferred (even if it isn't, actually, during processing).
We'll stop selecting transactions from a given sender once we detect (under the assumption above) that she doesn't have enough balance to pay the fee for the "currentTransaction".
raduchis
previously approved these changes
Nov 28, 2024
andreibancioiu
dismissed
raduchis’s stale review
The base branch was changed.
raduchis
approved these changes
Nov 28, 2024
AdoAdoAdo
approved these changes
Nov 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we don't select not-executable transactions (at all). Here, we handle transactions whose execution fee cannot be paid (anymore) by the sender.
Integration PR: