Mempool: completely handle fees and transferred balances within "detectWillFeeExceedBalance()" #6637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
commented
Nov 27, 2024
| return nil | ||
| } | ||
|
|
||
| if function != core.BuiltInFunctionMultiESDTNFTTransfer { |
There was a problem hiding this comment.
Superfluous (somehow)?
AdoAdoAdo
previously approved these changes
Nov 28, 2024
raduchis
reviewed
Nov 28, 2024
|
|
||
| accumulatedNativeValue := big.NewInt(0) | ||
|
|
||
| for _, transfer := range esdtTransfers.ESDTTransfers { |
There was a problem hiding this comment.
does this add a negligible overhead? A lot of transactions are with MultiESDTNFTTransfer
can the entire method be parallelized?
There was a problem hiding this comment.
Very good question, will benchmark ASAP 🙌
There was a problem hiding this comment.
// NOTE: 20% is also due to the require() / assert() calls.
// 0.012993s (TestBenchmarkSelectionSession_GetTransferredValue/numTransactions_=_5_000)
// 0.024580s (TestBenchmarkSelectionSession_GetTransferredValue/numTransactions_=_10_000)
// 0.048808s (TestBenchmarkSelectionSession_GetTransferredValue/numTransactions_=_20_000)
Thus, if we select ~10k, about 20 milliseconds (a bit much) will be spent in GetTransferredValue(). The selection duration is capped, though. There is still room for optimization.
We can move the call to GetTransferredValue() to the moment the transaction is added to the pool (additions are concurrent, also).
andreibancioiu
dismissed
AdoAdoAdo’s stale review
The base branch was changed.
raduchis
approved these changes
Nov 28, 2024
andreibancioiu
commented
Nov 28, 2024
| // 2. proposer will have those 3 transactions in its pools and will propose a block | ||
| // 3. another node will be able to sync the proposed block (and request - receive) the 2 transactions that | ||
| // will end up in the block (one valid and one invalid) | ||
| // 4. the non-executable transaction will be removed from the proposer's pool | ||
| // 4. the non-executable transaction will not be immediately removed from the proposer's pool. See MX-16200. |
AdoAdoAdo
approved these changes
Nov 28, 2024
This was referenced Nov 29, 2024
Mempool optimization: on transaction addition, call "GetTransferredValue" and retain its value
#6641
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?