[MEX-527] Pairs memory store service #1539
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add service that implements the memory store interface (can be used seamless by the plugin) - add util for creating a model from an array of fields; handles special case of '__typename' being requested - add `@Expose` decorator to all args fields for both the `pairs` and `filteredPairs` queries so that they work with the `plainToInstance` function in class-transformer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning
pairsandfilteredPairsqueries are causing significat performance degration because of the complexity of the Pair Model, and the fact that both can return lists of 300+ elements (mainnet)Proposed Changes
@Exposedecorator to all args fields for both thepairsandfilteredPairsqueries so that they work with theplainToInstancefunction in class-transformerHow to test