[Surrey] Cobrand & integration #5095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5095 +/- ##
==========================================
- Coverage 82.62% 82.48% -0.15%
==========================================
Files 405 406 +1
Lines 31579 31685 +106
Branches 5013 5032 +19
==========================================
+ Hits 26093 26136 +43
- Misses 3999 4059 +60
- Partials 1487 1490 +3 ☔ View full report in Codecov by Sentry. |
lucascumsille
force-pushed
the
surrey-cobrand
branch
from
1f24fbc
to
6d59c3e
Compare
davea
force-pushed
the
surrey-cobrand
branch
from
1271058
to
39af30b
Compare
- New style for tiles new reported problems - Added Bold to H1 and H2 - Added subscribe form to footer - Changed background for .box-warning - Updated style for hero section
davea
force-pushed
the
surrey-cobrand
branch
2 times, most recently
from
c4ae421
to
e7f564c
Compare
Closed/fixed for 31 days, open for 90 days.
Previously this only happened for the top-level mixed-in list.
Adds a column, "Subscribers" which uses the problem alert method to populate the number for subscribers. The original reporter is not automatically subscribed to their own report for Surrey so the figure is those that have subscribed after the report has been created. mysociety/societyworks#4369
davea
force-pushed
the
surrey-cobrand
branch
from
e7f564c
to
a61bbf7
Compare
Temporary fix ahead of training - proper solution is to remove Zendesk_ prefix from display
- Hide FMS report ID on confirmation page - use custom wording in header - Remove mention of email for anonymous reports - Add more helpful text to anonymous report confirmation page
davea
force-pushed
the
surrey-cobrand
branch
from
a61bbf7
to
d6d501f
Compare
Decision to use OSM after testing https://3.basecamp.com/4020879/buckets/36546415/todos/7645235529
Surrey don't want to show their backend ids to anybody so remove those from the email and site https://3.basecamp.com/4020879/buckets/36546415/todos/7611442254#__recording_7688243427
This allows you to update existing contacts when importing a JSON file. Handy to e.g. batch update emails, or add parent categories, etc.
Setting a `suggestions` value to 0 within the nearby_distances cobrand
feature disables the dupe suggestion feature for that group/category, eg:
COBRAND_FEATURES:
nearby_distances:
my_cobrand:
suggestions:
_fallback: 100
Potholes: 0
davea
force-pushed
the
surrey-cobrand
branch
from
d6d501f
to
9142e52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made of smaller PRs that have been individually reviewed and merged in.