Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bexley][WW] Handle container removal requests #5234

Conversation

nephila-nacrea
Copy link
Contributor

@nephila-nacrea nephila-nacrea commented Oct 28, 2024

For https://github.com/mysociety/societyworks/issues/4576 and some of https://github.com/mysociety/societyworks/issues/4575.

The normal 'request new' journey also includes options for removal, if property has containers that can be removed.
There is also a separate journey that handles removals only.

[skip changelog]

@nephila-nacrea nephila-nacrea changed the base branch from master to bexley-ww-container-requests October 28, 2024 23:22
@nephila-nacrea nephila-nacrea self-assigned this Oct 28, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 98.42520% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.53%. Comparing base (e623f62) to head (0f878b2).
Report is 6 commits behind head on bexley-ww-container-requests.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Bexley/Waste.pm 98.07% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           bexley-ww-container-requests    #5234      +/-   ##
================================================================
+ Coverage                         82.47%   82.53%   +0.06%     
================================================================
  Files                               410      410              
  Lines                             32197    32730     +533     
  Branches                           5147     5160      +13     
================================================================
+ Hits                              26554    27015     +461     
- Misses                             4128     4199      +71     
- Partials                           1515     1516       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nephila-nacrea nephila-nacrea force-pushed the bexley-ww-container-requests-removal branch 2 times, most recently from 690b4df to 8e58de9 Compare October 29, 2024 22:55
@dracos dracos force-pushed the bexley-ww-container-requests branch 2 times, most recently from 99bbc13 to 41457d7 Compare October 30, 2024 16:46
@nephila-nacrea nephila-nacrea force-pushed the bexley-ww-container-requests-removal branch from 40d9a9f to d9eabfc Compare October 31, 2024 11:20
@nephila-nacrea nephila-nacrea force-pushed the bexley-ww-container-requests-removal branch from d9eabfc to 472eb56 Compare October 31, 2024 12:47
@nephila-nacrea nephila-nacrea marked this pull request as ready for review October 31, 2024 13:09
@nephila-nacrea nephila-nacrea changed the title Bexley ww container requests removal [Bexley][WW] Handle container removal request Oct 31, 2024
@nephila-nacrea nephila-nacrea changed the title [Bexley][WW] Handle container removal request [Bexley][WW] Handle container removal requests Oct 31, 2024
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clear, just a few small suggestions.
We can probably (later) look at if all the request forms can be refactored in a way to share bits (e.g. Kingston also has a removal page).

templates/web/bexley/waste/summary_request.html Outdated Show resolved Hide resolved
perllib/FixMyStreet/App/Controller/Waste.pm Outdated Show resolved Hide resolved
perllib/FixMyStreet/Cobrand/Bexley/Waste.pm Outdated Show resolved Hide resolved
perllib/FixMyStreet/Cobrand/Bexley/Waste.pm Outdated Show resolved Hide resolved
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@nephila-nacrea nephila-nacrea force-pushed the bexley-ww-container-requests-removal branch from a60c732 to 0f878b2 Compare November 4, 2024 13:32
@nephila-nacrea nephila-nacrea merged commit 0f878b2 into bexley-ww-container-requests Nov 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants