-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bexley][WW] Handle container removal requests #5234
[Bexley][WW] Handle container removal requests #5234
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## bexley-ww-container-requests #5234 +/- ##
================================================================
+ Coverage 82.47% 82.53% +0.06%
================================================================
Files 410 410
Lines 32197 32730 +533
Branches 5147 5160 +13
================================================================
+ Hits 26554 27015 +461
- Misses 4128 4199 +71
- Partials 1515 1516 +1 ☔ View full report in Codecov by Sentry. |
690b4df
to
8e58de9
Compare
99bbc13
to
41457d7
Compare
40d9a9f
to
d9eabfc
Compare
d9eabfc
to
472eb56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and clear, just a few small suggestions.
We can probably (later) look at if all the request forms can be refactored in a way to share bits (e.g. Kingston also has a removal page).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Can be standalone or done as part of the delivery request flow
Please enter the commit message for your changes. Lines starting
a60c732
to
0f878b2
Compare
For https://github.com/mysociety/societyworks/issues/4576 and some of https://github.com/mysociety/societyworks/issues/4575.
The normal 'request new' journey also includes options for removal, if property has containers that can be removed.
There is also a separate journey that handles removals only.
[skip changelog]