-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for redirect http code in transition plugin #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename guard to transtionhookexecutor
stas-nc
requested review from
m2broth,
blackrabbit99,
b1ff,
wRLSS,
yehor-manzhula and
harnyk
December 20, 2024 15:02
stas-nc
force-pushed
the
feature/redirect
branch
from
December 23, 2024 18:33
def8574
to
4919ece
Compare
ilc/server/types/RegistryConfig.ts
Outdated
domain?: string; | ||
}; | ||
|
||
export type SpecialRoute = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it makes sense to introduce some common parent interface for Route and SpecialRoute?
stas-nc
force-pushed
the
feature/redirect
branch
2 times, most recently
from
December 24, 2024 11:00
fec8d45
to
273db3f
Compare
wRLSS
approved these changes
Dec 24, 2024
stas-nc
force-pushed
the
feature/redirect
branch
from
December 24, 2024 12:08
273db3f
to
b041f19
Compare
stas-nc
force-pushed
the
feature/redirect
branch
from
December 24, 2024 12:08
b041f19
to
88d9207
Compare
yehor-manzhula
approved these changes
Dec 24, 2024
Coverage ReportIlc/serverCommit SHA:07e35fd202557d18a00d804e6932b181a8964101 Test coverage results 🧪
File details
Ilc/clientCommit SHA:07e35fd202557d18a00d804e6932b181a8964101 Test coverage results 🧪
File details
Registry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally: