[Chore] Create separate stream constructor for Resource #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #97 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 1191 1194 +3
=========================================
+ Hits 1191 1194 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it simpler to work with
Resource: the users are forced to provide thefetcherwith the default constructor (like with SolidJS). In case the user wants to provide a stream, then a different constructor is needed. This way it becomes impossible to provide:streamandfetcherBy getting rid of the two scenarios above, type inference also becomes very accurate.
This PR introduced a breaking change, but I think it is fine, since v2 will bring other breaking changes as well.