Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Fix problems detected by VSCode #99

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

manuel-plavsic
Copy link
Collaborator

@manuel-plavsic manuel-plavsic commented Dec 28, 2024

This PR fixes all the remaining problems that VSCode detects (note: I used the main channel, maybe some of the warnings do not appear yet on stable).

I was unsure whether to remove the keys entirely or to replace

ignore: unused_element

with the new:

ignore: unused_element_parameter

Since the keys are not used and it may be slightly confusing to keep them, I decided to remove them.

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c2c53ed) to head (40cded2).
Report is 1 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               dev       #99   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1194      1194           
=========================================
  Hits          1194      1194           
Files with missing lines Coverage Δ
...ckages/flutter_solidart/lib/src/widgets/solid.dart 100.00% <ø> (ø)

@nank1ro
Copy link
Owner

nank1ro commented Dec 29, 2024

Are you using the latest stable of Flutter?

@manuel-plavsic
Copy link
Collaborator Author

manuel-plavsic commented Dec 29, 2024

The latest main:

> flutter --version
Flutter 3.28.0-2.0.pre.38587 • channel main • https://github.com/flutter/flutter.git
Framework • revision b15625ca92 (35 hours ago) • 2024-12-27 15:26:24 -0800
Engine • revision b15625ca92
Tools • Dart 3.7.0 (build 3.7.0-267.0.dev) • DevTools 2.41.0

@nank1ro
Copy link
Owner

nank1ro commented Dec 29, 2024

The problem is that they deprecated and replaced stuff of main, but on stable the new stuff is not there yet, this PR cannot land

Copy link
Owner

@nank1ro nank1ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nank1ro nank1ro merged commit 640256b into nank1ro:dev Dec 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants