Backfill synonym slugs (DO NOT MERGE) #2785
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2785 +/- ##
========================================
- Coverage 6.08% 5.91% -0.17%
========================================
Files 171 172 +1
Lines 4340 4361 +21
Branches 476 480 +4
========================================
- Hits 264 258 -6
- Misses 4074 4101 +27
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
so I tried it without the region and it doesn't work without a region. Just for future reference. I added it back in and was able to run things fine. |
Interesting. I think I have |
app/backfill-synonym-slugs.js
Outdated
| } catch (error) { | ||
| console.error('Error fetching table name from SSM:', error) | ||
| throw error | ||
| } |
There was a problem hiding this comment.
FWIW, you could safely remove this entire try/except block. You'll get a good stack trace either way.
| const startTime = new Date() | ||
| console.log('Starting SYNONYM SLUG backfill... ', startTime) |
There was a problem hiding this comment.
Consider console.time and console.timeEnd.
|
There is no more test data to test this script. The only env left with data is prod. |
OK, what's your new test strategy? If we could only ever test this once, then perhaps we did not have an adequate test strategy. |
DO NOT MERGE!!! for review only
closes #2784