Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backfill synonym slugs (DO NOT MERGE) #2785
base: main
Are you sure you want to change the base?
Backfill synonym slugs (DO NOT MERGE) #2785
Changes from 4 commits
c7d450e
2facdd6
2ee0614
b97fab7
7761748
51c2929
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 9 in app/backfill-synonym-slugs.js
app/backfill-synonym-slugs.js#L8-L9
Check warning on line 13 in app/backfill-synonym-slugs.js
app/backfill-synonym-slugs.js#L11-L13
Check warning on line 16 in app/backfill-synonym-slugs.js
app/backfill-synonym-slugs.js#L16
Check warning on line 19 in app/backfill-synonym-slugs.js
app/backfill-synonym-slugs.js#L19
Check warning on line 22 in app/backfill-synonym-slugs.js
app/backfill-synonym-slugs.js#L21-L22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, you could safely remove this entire
try
/except
block. You'll get a good stack trace either way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider
console.time
andconsole.timeEnd
.Check warning on line 32 in app/backfill-synonym-slugs.js
app/backfill-synonym-slugs.js#L26-L32
Check warning on line 34 in app/backfill-synonym-slugs.js
app/backfill-synonym-slugs.js#L34
Check warning on line 39 in app/backfill-synonym-slugs.js
app/backfill-synonym-slugs.js#L36-L39
Check warning on line 41 in app/backfill-synonym-slugs.js
app/backfill-synonym-slugs.js#L41
Check warning on line 45 in app/backfill-synonym-slugs.js
app/backfill-synonym-slugs.js#L45
Check warning on line 47 in app/backfill-synonym-slugs.js
app/backfill-synonym-slugs.js#L47
Check warning on line 59 in app/backfill-synonym-slugs.js
app/backfill-synonym-slugs.js#L58-L59
Check warning on line 64 in app/backfill-synonym-slugs.js
app/backfill-synonym-slugs.js#L63-L64
Check warning on line 67 in app/backfill-synonym-slugs.js
app/backfill-synonym-slugs.js#L67