Module loaders

[Benjaki2]

Resolves #494
Fixes #528
Fixes #673

Depends on nasa-gibs/worldview-components#32

Outstanding Items

Features to be modularized and re-enabled

• Core
• Tour - @ZachTRice Enable tour features #639
• Animation - @Benjaki2 Module loaders for animation feature #640
• Data Download - @Benjaki2 Modularize Data Download #654
• Image Download - @Benjaki2 Module loaders for image download #645
• Natural Events - @localjo Modularize natural events #648
• Notifications - @Benjaki2 Modularize notification feature #644
• URL Shortening (done along with other features)
• Custom Palettes (done along with other features)
• What's New - @Benjaki2 (Modularize notification feature #644)
• Feedback (done along with Enable tour features #639)
• Arctic Projection Change - @localjo Enable arctic projection change #650
• Google Analytics (done along with other features)
• Alert (done along with other features)
• Timeline mobile wheels - @localjo Modularize mobile timeline wheel #651
• Debug.js - @localjo Finish modularizing debug.js #653

Update Buster Tests

All tests should be modularized, and the code should be tested against them before that section is marked complete)

• Core files (fixtures.js, wv.brand-test.js)
• Data
• Date
• Layer
• Link
• Map
• Palettes
• Proj
• UI
• Util

Other Tasks

• Clean up build scripts
• Remove converted dependencies (wv.js.json, dependencies, etc.)
• Move all dependencies from /ext to package.json
• Make sure all required CSS files are included (some have been removed)
• Shim or include jscache library in package.json
• Enable watch mode for JS and CSS build tasks - @localjo Update build scripts #647
• Make build script work for dev and production environments - @localjo Update build scripts #647

Bugs

• Fix projection button (Getting the error "Cannot read property 'close' of undefined in projection/projection/ui.js")
• Fix "Add layer" errors (in layer module)
• Fix error related to WVC on tab switching
• The URL state is not updating
• iCheck boxes are missing iCheck iCheck-checkbox classes on div which is affecting the styling
• Hovering a layer on the map the includes a colorbar does not update the label in the sidebar. (.wv-running / .wv-active classes not being added from map/runningdata.js)
• jQuery.easing[this.easing] is not a function error when opening projection switcher.
• Styling of projection dropdown is off (more spacing and not highlighted)
• React.createElement: type should not be null, undefined, boolean, or number. It should be a string (for DOM elements) or a ReactClass (for composite components). when trying to open share link button.
• jQuery UI default stylesheet changing causes a number of elements to appear different.
  -- Text appears darker than before. This can be seen in the Events / Date tab, Measurement setting tab (Add Layers modal),
  -- The "Squash Layer" checkbox in the sidebar has no border and is missing padding/margin right
  -- The radio "check" buttons under Color palettes in the sidebar is missing thick borders
  -- jQuery UI default font-stack is no longer Segoe UI,Arial,sans-serif, it is Verdana,Arial,sans-serif, so the "Add Layers" button looks different
• Add Layers -> Measurements description drawer button not working (no error displayed)
  Note* This is related to toggle-event being removed in jQuery 1.9+ (https://api.jquery.com/toggle-event/)
• Map Scale Bug

Cleanup

• Final pass over main.js @localjo Finish main.js modularization #656
• Make sure all lodash variables are using the same naming convention
• Review usage of NODE_ENV in production - @localjo Clean Up Build Scripts #659
• Make sure build script changes work with GIBS options repo - @localjo Clean Up Build Scripts #659
• Move all build scripts into a single directory (instead of root, /bin, /tasks, and /deploy) - @localjo Clean up project structure and simplify build scripts #664
• Run e2e tests to confirm functionality
• Run test deployment on SIT/UAT (May need to coordinate with Jon) - @localjo Clean up project structure and simplify build scripts #664
• Update worldview-private deployment scripts - @localjo
• Fix Babel not compiling WVC code
• Go through manual test plan
• Fix any bugs found (see bugs attached to Milestone)
• Review all documentation to make sure it's up to date
• Release Remove Browserify Shim worldview-components#32 and update package.json

[Benjaki2]

Note 2** there are onload functions in wv.util.browser to be reworked into the onload function in wv.main.js

[localjo]

Getting this message on npm install;

We're super 😸 excited that you're trying to use ES2015 syntax, but instead of making more yearly presets 😭 , Babel now has a better preset that we recommend you use instead: npm install babel-preset-env --save-dev. preset-env without options will compile ES2015+ down to ES5 just like using all the presets together and thus is more future proof. It also allows you to target specific browsers so that Babel can do less work and you can ship native ES2015+ to user 😎 ! We are also in the process of releasing v7, so please give http://babeljs.io/blog/2017/09/12/planning-for-7.0 a read and help test it out in beta! Thanks so much for using Babel 🙏, please give us a follow on Twitter @babeljs for news on Babel, join slack.babeljs.io for discussion/development and help support the project at opencollective.com/babel

[Benjaki2]

@localjo Yeah I saw that yesterday. Need to switch the preset-package-name