-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflected light phase curves #192
Open
colinhamill
wants to merge
19
commits into
natashabatalha:dev
Choose a base branch
from
Rowan-Nag:master
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a 'transfer' and 'shift' to atmosphere_4d and clouds_4d to fix phase curves for reflected cases. Various other lines, related to lab scattering approximations, have been commented out for now. Jit is now back on for fluxes.py > get_reflected_3d
Most recent version. Adjustments made to justdoit.py make micro adjustments in reflected light phase curves.
Added ng, nt =6 calculations. Added PICASO Branch print statement in atm_4d
deleted lots of stuff that is now in picaso_lab
@colinhamill would it be possible to resubmit this PR into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added changes to allow calculation of reflected light phase curves. Most notable changes are confined to atmosphere_4d and clouds_4d in justdoit.py. I also assumed symmetry across phase = 0 deg (secondary eclipse) in fluxes.py > get_reflected_3d in order to calculate reflected phase intensity from 0-360 degrees.