-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflected light phase curves #192
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
00da179
Update README.md
Rowan-Nag 8ceec94
Added Collin's code for atmsetup, fluxes, and justdoit.py
Rowan-Nag c2689d7
changed file paths to /KCL_data
Rowan-Nag 6832e38
Updated clouds_4d with same changes to atmosphere_4d
Rowan-Nag effb5a4
fixed ubar, now reflected case works
colinhamill a1156af
Merge branch 'master' of https://github.com/Rowan-Nag/picaso
colinhamill bd0bdca
Update fluxes.py
colinhamill 8a97143
Update disco.py
colinhamill 5b569b2
Fixed phase curve output with a transfer and shift in atm_4d
colinhamill 67de0f1
PICASO justdoit/atmsetup/justplotit 02/15/24
colinhamill ddaa6b5
Update justdoit.py
colinhamill c718035
Delete commented out stuff
colinhamill 86d55e1
deleting more stuff
colinhamill 7b51e3c
Cleaned more code
Rowan-Nag 9b639da
Merge remote-tracking branch 'upstream/master'
colinhamill 1e5664b
readme fix for PR
Rowan-Nag 4d3a8e5
Cleaned whitespace & numpy dependency for PR
Rowan-Nag ea4f9c3
jdi formatting & import fix for PR
Rowan-Nag 538b927
Update justplotit.py
Rowan-Nag 55b6fe2
Update justplotit.py
colinhamill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colinhamill am I okay to comment this out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or does it add some functionality ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this can be commented out or removed. This part is used for the Lab vs. DDA vs. HG study, and I forgot to remove it. It does not impact the reflected phase curve functionality.