Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix orderedset #10

Open
wants to merge 73 commits into
base: develop
Choose a base branch
from
Open

Conversation

joeflack4
Copy link

Updates

Changed dependency: orderedset -> ordered-set

  • ordered-set: Switched from CPython-based non-precompiled 'orderedset' to pure Python-based 'ordered-set' functionality. The API seems similar / same, and should be especially OK to do this because it doesn't look like this it's being used yet in the project.

Related to

simonpercivall/orderedset#31

Issues with this pull request

I'm not sure which branch to merge this into. I'm hoping this is also the correct repository. The remote I'm using is labeled https://github.com/ncihtan/HTAN-data-pipeline.git, and the branch is develop. But that repository redirects to ncihtan/schematic when I try to access it.

Additionally, I'm seeing a different commit histories here. Perhaps HTAN-data-pipeline is private and I'm getting redirected?
The last commit I see in ncihtan/schematic is:

commit 12a8eed20a3fed2f00034ece3e2934aa9f1ac2f3
Merge: 6ab4457 4063c45
Author: milen-sage <[email protected]>
Date:   Tue May 26 11:32:49 2020 -0700

    Merge pull request #1 from xdoan/patch-1

    Create LICENSE.txt

But the last one I'm seeing in `ncihtan/HTAN-data-pipeline is:

commit 5c3ac5d167786ed2d94ec672ddf67adfad4e7d45
Merge: 3c717b0 426ada8
Author: milen-sage <[email protected]>
Date:   Mon Mar 8 16:31:18 2021 -0800

    Merge pull request #7 from milen-sage/main

    Pulling schema updates from origin

xdoan and others added 30 commits May 26, 2020 11:29
removing unneeded htan csv file from schema folder
…a-update

Corrections to HTAN biospecimen schema
…a-update

Changes to bulk WES to account for ctDNA and cfDNA; corrections to scATA-seq level 1
…hierarchy

Support listing all files in a dataset independent of folder hierarchy in the dataset
Pulling latest code from upstream
…a-update

Schema updates - imaging level 1 and 2; biospecimen final updates
…a-update

Very minor update to biospecimen ID description
Added issue templates for people to use when filing bug reports and feature requests
…a-update

Added updates to clinical data schema: molecular test; tier 2; tier 3
… data validation dropdowns when latter are derived from workbook range
milen-sage and others added 29 commits December 18, 2020 13:59
…a-update

Minor updates: adding MERFISH to imaging level 2
…a-update

Added Nuclei Isolation as an option for scRNA-seq level 1 Single Cell…
…usly only columns with dropdowns containing more than 10 items were explicitly added to the hidden sheet; this addresses a user-request from HTAN
Storing valid values in hidden sheet of metadata template
…im_commas_df-bugfix

trim_commas_df to remove only trailing empty columns
Removing unneeded calls to Synapse from synapse store
Re: Sage-Bionetworks#397 add useSchemaLabel param to store.associateMetadataWithFiles
Fixing a typo.
…TAC-seq based on requests from data contributors
Getting latest codebase and schema from upstream
…in biothings, which does not have displayName attribute
Pulling schema updates from origin
- ordered-set: Switched from CPython-based non-precompiled 'orderedset' to pure Python-based 'ordered-set' functionality. The API seems similar / same, and should be especially OK to do this because it doesn't look like this it's being used yet in the project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants