-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stateless_validation] Deprecate ChunkEndorsementTrackerV1 #12131
Merged
shreyan-gupta
merged 7 commits into
master
from
shreyan/stateless_validation/deprecate_tracker_v1
Nov 4, 2024
Merged
[stateless_validation] Deprecate ChunkEndorsementTrackerV1 #12131
shreyan-gupta
merged 7 commits into
master
from
shreyan/stateless_validation/deprecate_tracker_v1
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tayfunelmas
approved these changes
Sep 24, 2024
…on/deprecate_tracker_v1
…on/deprecate_tracker_v1
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12131 +/- ##
==========================================
- Coverage 71.65% 71.64% -0.02%
==========================================
Files 839 837 -2
Lines 170357 170109 -248
Branches 170357 170109 -248
==========================================
- Hits 122065 121868 -197
+ Misses 42928 42887 -41
+ Partials 5364 5354 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shreyan-gupta
deleted the
shreyan/stateless_validation/deprecate_tracker_v1
branch
November 4, 2024 13:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #11978
Now that ChunkEndorsementV2 is in production, we can get rid of ChunkEndorsementV1 with the next protocol upgrade.
Note: To be merged only after branch cut for 2.3.0