Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stateless_validation] Deprecate ChunkEndorsementTrackerV1 #12131

Merged

Conversation

shreyan-gupta
Copy link
Contributor

@shreyan-gupta shreyan-gupta commented Sep 23, 2024

Follow up on #11978

Now that ChunkEndorsementV2 is in production, we can get rid of ChunkEndorsementV1 with the next protocol upgrade.

Note: To be merged only after branch cut for 2.3.0

@shreyan-gupta shreyan-gupta added this pull request to the merge queue Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 90.41096% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.64%. Comparing base (ad96419) to head (c2ea9c2).
Report is 152 commits behind head on master.

Files with missing lines Patch % Lines
...ives/src/stateless_validation/chunk_endorsement.rs 88.00% 6 Missing ⚠️
chain/network/src/network_protocol/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12131      +/-   ##
==========================================
- Coverage   71.65%   71.64%   -0.02%     
==========================================
  Files         839      837       -2     
  Lines      170357   170109     -248     
  Branches   170357   170109     -248     
==========================================
- Hits       122065   121868     -197     
+ Misses      42928    42887      -41     
+ Partials     5364     5354      -10     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (+<0.01%) ⬆️
db-migration 0.16% <0.00%> (+<0.01%) ⬆️
genesis-check 1.26% <0.00%> (+<0.01%) ⬆️
integration-tests 39.26% <90.41%> (-0.06%) ⬇️
linux 70.64% <90.41%> (-0.01%) ⬇️
linux-nightly 71.20% <90.41%> (-0.03%) ⬇️
macos 50.50% <78.08%> (+0.01%) ⬆️
pytests 1.57% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.38% <0.00%> (+<0.01%) ⬆️
unittests 64.24% <78.08%> (+0.04%) ⬆️
upgradability 0.21% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into master with commit 524eca9 Nov 4, 2024
29 checks passed
@shreyan-gupta shreyan-gupta deleted the shreyan/stateless_validation/deprecate_tracker_v1 branch November 4, 2024 13:33
@shreyan-gupta shreyan-gupta added the A-stateless-validation Area: stateless validation label Dec 9, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 16, 2024
We missed that when refactoring chunk endorsement logic. The old
`ChunkEndorsement` message was removed in #12131, but we forgot to add
the new message introduced in #11091.
I've noticed that by looking at mainnet metrics where
`VersionedChunkEndorsement` message is only sent via T2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-stateless-validation Area: stateless validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants