Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrides default value for dask-labextension #1327

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Conversation

viniciusdc
Copy link
Contributor

Fixes | Closes | Resolves #1326

Changes introduced in this PR:

  • Updates the default value of browserDashboardCheck from False to True
    This will guarantee that every spawned profile has the fix for the dask-gateway and dask-labextension dashboard issue.

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Maintance related task.

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Further comments (optional)

This is a very simple addition to address the remaining needs of #1012

@viniciusdc
Copy link
Contributor Author

This is not blocked by #1321 but it's recommended to have that one merged first.

@viniciusdc viniciusdc added the needs: review 👀 This PR is complete and ready for reviewing label Jun 14, 2022
@viniciusdc viniciusdc requested a review from iameskild June 14, 2022 14:31
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!
My only question is how are these overrides handled? I don't see this json referenced anywhere else.

@viniciusdc
Copy link
Contributor Author

viniciusdc commented Jun 14, 2022

This looks good to me! My only question is how are these overrides handled? I don't see this json referenced anywhere else.

For this case specifically (an extension) Jupyterlab has a mechanism to override extension settings using an overrides.json file, which is a little bit different than the usual override options available for the user in our configuration.
In other words, we shouldn't expect the user to change this.

@viniciusdc viniciusdc added status: merge-ready and removed needs: review 👀 This PR is complete and ready for reviewing labels Jun 14, 2022
@viniciusdc
Copy link
Contributor Author

viniciusdc commented Jun 14, 2022

This was tested already with a GCP deployment.
image

image

@viniciusdc viniciusdc merged commit ed81f61 into main Jun 14, 2022
@iameskild
Copy link
Member

Beautiful! Thanks a lot @viniciusdc :)

@iameskild iameskild deleted the fix-1326-dasklab branch June 14, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Enable Dask-labextension settings automatic from config
2 participants