-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update serverless3 node20 #56
Conversation
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "serverless-provisioned-concurrency-autoscaling", | |||
"version": "1.9.1", | |||
"version": "2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think will make a breaking change. Last time I tried it we had to roll back. Probably best to go with 1.10.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claydanford There is a breaking change with this PR. The serverless 3 update resulted in change in schema since pc attribute is now a default thats defined in serverless3 and also role creation standards have changed
When merged, I will cut a release to NPM. |
@vinothchandrasekarNM , can you please put a comment in the readme about version deps? <v1.9.1 for sls v1 and v2, v2.0.0 for sls v3. |
Sure will add the details. Testing it internally will merge after the tests have passed. |
Should we check for the sls version in the plugin? |
@claydanford I've updated the README with version guidance. I checked some serverless plugins and I dont see a version check. Do we still need it? |
sls v3 has been out for a while so we are okay to not include the check. |
No description provided.