-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Move]
Part-6 Classes into Different Library - Neo.Extensions
#3410
Open
cschuchardt88
wants to merge
49
commits into
neo-project:master
Choose a base branch
from
cschuchardt88:rebuild/the-split-6
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Move]
Part-6 Classes into Different Library - Neo.Extensions
#3410
cschuchardt88
wants to merge
49
commits into
neo-project:master
from
cschuchardt88:rebuild/the-split-6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`, `AssemblyExtensions`, `StringExtensdions` Deleted `Helper.cs` file
cschuchardt88
added
Blocked
This issue can't be worked at the moment
Waiting for Review
labels
Jul 7, 2024
…8/neo into rebuild/the-split-2
cschuchardt88
added
Blocker
Issues that are blocking other issues. Check issues details to see what it is blocking.
Waiting for Review
and removed
Blocked
This issue can't be worked at the moment
labels
Sep 28, 2024
Jim8y
reviewed
Sep 28, 2024
shargon
reviewed
Sep 30, 2024
shargon
requested changes
Sep 30, 2024
Jim8y
reviewed
Nov 13, 2024
/// </summary> | ||
/// <param name="data">The compressed data.</param> | ||
/// <param name="maxOutput">The maximum data size after decompression.</param> | ||
/// <returns>The original data.</returns> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that adding new methods will make it easier to do the work, and actually it wont cause any trouble, but please avoid doing so.
Jim8y
approved these changes
Nov 13, 2024
vncoelho
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Blocker
Issues that are blocking other issues. Check issues details to see what it is blocking.
Waiting for Review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reorganized and move classes from
neo
library toneo.extensions
library.Fixed problems and warnings that occurred. Along with naming violations.
Change Log
Neo.IO.Helper
classBinaryReaderExtensions
,BinaryWriterExtensions
,MemoryReaderExtensions
,SpanExtensions
classesStringExtensions
,ByteExtensions
MemoryExtensions
using
statementType of change
How Has This Been Tested?
Checklist: