-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Enchantments page #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
Generally, this needs a lot more detail. It is too sparse to have an understanding on how to properly use the system. One example of this is the value effects, as that is hard to wrap your head around if you do not have a solid understanding of what is going on.
You should incorporate more information and examples of how one would implement these custom methods. Create a fake object that holds some arbitrary conditions. It should help the reader better understand how to create an enchantment.
I think I've applied all these changes, let me know if there's more still to do! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! I will say there needs to be a lot more detail and narrative dialogue to help with the understanding of the document. It was hard to get a sense of how the system worked without already being aware of the logic itself. It's best if you take a step back and imagine if someone who had no knowledge of the system, would they be able to understand what you've written.
Co-authored-by: ChampionAsh5357 <[email protected]>
Co-authored-by: ChampionAsh5357 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't go through it in detail again, but looks good overall. Approved by me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress! However, I do think there needs to be a bit more explanation with your current reorganization. There are also some minor inaccuracies here and there that need to be fixed.
Co-authored-by: ChampionAsh5357 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the work you've done! Just two more changes: one syntax based and the other due to providing a understandable baseline.
Once these two are addressed, I don't believe I have any more comments for its current state.
Got it! Thank you so much for your patience and advice in leading me through this project. |
Adds a page under Resources > Server that describes how to make custom Enchantments and Enchantment Component Types in 1.21.x, as well as a small amount about how to work with the latter.
The relevant minecraft.wiki pages are frequently referenced and linked to, but the written content is my own.
Looking for feedback on this draft!
This should address issue #132
Preview URL: https://pr-165.neoforged-docs-previews.pages.dev