Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enchantments page #165

Merged
merged 43 commits into from
Oct 13, 2024
Merged

Add Enchantments page #165

Changes from 13 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
b4d0d5b
Add a page for Enchantments
hjake123 Sep 17, 2024
350326c
Contribution standards cleanup 1
hjake123 Sep 17, 2024
98b98b7
typo
hjake123 Sep 17, 2024
ac75724
Address review until ValueEffect
hjake123 Sep 18, 2024
82d856e
Reworked Value Effect Components section
hjake123 Sep 18, 2024
f778f72
Rework Entity Effect Component and Location Based Effect Component se…
hjake123 Sep 18, 2024
dac1fbe
Add Data Generation section
hjake123 Sep 23, 2024
a68b955
Vanilla Enchantment Value Component Types section
hjake123 Sep 26, 2024
188aeed
Vanilla Enchantment Entity Effect Component Types section
hjake123 Sep 26, 2024
9acd8e1
Other Vanilla Enchantment Component Types section
hjake123 Sep 26, 2024
2b01b68
Vanilla Enchantment Entity Effects section
hjake123 Sep 26, 2024
8b99906
Reorganize the vanilla enchantment component types sections
hjake123 Sep 26, 2024
57472fa
Merge branch 'neoforged:main' into enchantments
hjake123 Sep 26, 2024
b261913
Typo fix from conversation
hjake123 Sep 30, 2024
76b3644
Remove snakecase from conversation
hjake123 Sep 30, 2024
12c3485
Various improvements
hjake123 Oct 1, 2024
974ab22
Split into two pages and further revise
hjake123 Oct 1, 2024
b851f7a
Rearrange the Location Based Effect Component section and subsequent …
hjake123 Oct 1, 2024
56f9d0c
rewording
hjake123 Oct 1, 2024
713de34
Fix some incorrect headings
hjake123 Oct 1, 2024
fa4043e
Improve usage example
hjake123 Oct 1, 2024
cc63d51
Typo
hjake123 Oct 1, 2024
fd57b55
Simple fixes
hjake123 Oct 3, 2024
2d123e4
Formatting fixes
hjake123 Oct 3, 2024
55b2f2d
Links and more!
hjake123 Oct 3, 2024
50032ef
Fix more capitalized nouns
hjake123 Oct 3, 2024
1394c83
New Enchantment Costs section
hjake123 Oct 4, 2024
c0bf5e2
Adjust wording
hjake123 Oct 4, 2024
8146b47
Add a blank line after every subheading
hjake123 Oct 4, 2024
d4b0692
Add a blank line before and after codeblocks
hjake123 Oct 4, 2024
03f7640
Format JSON blocks to 2 space indents
hjake123 Oct 4, 2024
a13c73a
Remove an unclear segment.
hjake123 Oct 6, 2024
f93862b
Apply edit suggestions
hjake123 Oct 10, 2024
a6a9e4a
builtin review 4.1-4.3 (lacking datagen)
hjake123 Oct 10, 2024
2e9c0ae
attribute component confusion
hjake123 Oct 10, 2024
bbf6a80
Clarify the purpose of EnchantmentEntityEffect#apply
hjake123 Oct 10, 2024
d032dab
Datagen for examples
hjake123 Oct 10, 2024
d307e9b
Lag file mention
hjake123 Oct 10, 2024
6cdb9cf
No more static and more comments
hjake123 Oct 10, 2024
31da446
Untruth purge and custom component section rework
hjake123 Oct 10, 2024
946607a
Terminology fix for enchantment costs / levels
hjake123 Oct 10, 2024
51a9b76
camelCase
hjake123 Oct 12, 2024
706cbc8
Clarify the usage of LootContextParamSets
hjake123 Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading