Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make server configs used across saves by default #376

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

pupnewfster
Copy link
Member

@pupnewfster pupnewfster commented Dec 11, 2023

Make server configs generate in the normal config folder and allow overriding them on a per-world basis by use of the previously default location serverconfigs. This includes a minor breaking change in FML, but from a modpack/user perspective all existing worlds should continue to function identically as it will just load the configs they already have in serverconfigs as if they were overrides.

Requires neoforged/FancyModLoader#48

Edit: Just as a note this doesn't change anything behavior wise about defaultconfigs. Those still will function exactly as they currently do.

@HeatherComputer
Copy link

Huge fan of this - most people do not care for world-specific configs and leaving it as an option is great for the few that do

...and having stuff back in the config folder helps a lot of external systems which can't override configs in a world that does not yet exist

@quat1024
Copy link

Sounds great. I know i've decided against using server configs in the past just cause i knew i'd get a hundred "help i can't find the config" questions

@pupnewfster pupnewfster marked this pull request as ready for review December 12, 2023 18:16
@Technici4n Technici4n merged commit 4c56d6d into neoforged:1.20.x Dec 13, 2023
3 checks passed
@pupnewfster pupnewfster deleted the config_changes branch December 13, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants