refactor(write path): newtype to enforce use of fully initialized slices #8717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need this so we can pass in Bytes to the l0 flush code
github-actions
bot
added
the
external
2182 tests run: 2113 passed, 0 failed, 69 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
b55a70a at 2024-08-14T17:35:51.564Z :recycle: |
VladLazar
reviewed
Aug 14, 2024
problame
changed the title
bytes_init() == bytes_total()
5 tasks
bayandin
added a commit
that referenced
this pull request
Aug 15, 2024
## Problem On macOS, clippy fails with the following error: ``` error: unused import: `crate::virtual_file::owned_buffers_io::io_buf_ext::IoBufExt` --> pageserver/src/tenant/remote_timeline_client/download.rs:26:5 | 26 | use crate::virtual_file::owned_buffers_io::io_buf_ext::IoBufExt; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_imports)]` ``` Introduced in #8717 ## Summary of changes - allow `unused_imports` for `crate::virtual_file::owned_buffers_io::io_buf_ext::IoBufExt` on macOS in download.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tokio_epoll_uring::Slice/tokio_uring::Slicetype is weird.The new
FullSlicenewtype is better. See the doc comment for details.The naming is not ideal, but we'll clean that up in a future refactoring where we move the
FullSliceintotokio_epoll_uring. Then, we'll do the following:FullSlicebecomestokio_epoll_uring::IoBufViewtokio_epoll_uring::IoBufMutViewfor the currenttokio_epoll_uring::Slice<IoBufMut>Context
I did this work in preparation for #8537.
There, I'm changing the type that the
inmemory_layer.rspasses toDeltaLayerWriter::put_value_bytesand thus it seemed like a good opportunity to make this cleanup first.