WIP 5150 flush content cache correctly #5160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orkspace doesnt exist anymore
```
Scenario: When a change is applied to the forked content stream AFTER the fork, it is not visible in the live content stream. # Features/ContentStreamForking/ForkContentStreamWithoutDimensions.feature:61
And the event NodePropertiesWereSet was published with payload: # Features/ContentStreamForking/ForkContentStreamWithoutDimensions.feature:66
Neos\ContentRepository\Core\SharedModel\Exception\WorkspaceDoesNotExist: The source workspace user does not exist
```
The test scenario consists of a document with a main content collection that initially contains two simple text content nodes. During the scenario, we switch to a user workspace and insert a third text node between the two initial nodes. The test then verifies, that fusion renders all three text nodes in order. Afterwards we discard the change we just made and check whether fusion now stops rendering the discarded node. Confirming neos#5150, with this commit, said verification fails.
Discarded node move changes are reflected correctly in the document tree Scenario neos#2: Moved nodes do not just disappear after discarding the move change
mhsdesign
commented
Jun 23, 2024
Comment on lines
+138
to
+147
| if ($eventInstance instanceof WorkspaceWasPartiallyDiscarded) { | ||
| foreach ($eventInstance->discardedNodes as $discardedNode) { | ||
| $this->scheduleCacheFlushJobForNodeAggregate( | ||
| $this->contentRepository, | ||
| $eventInstance->workspaceName, | ||
| $discardedNode->nodeAggregateId | ||
| ); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
fixes one ui test
FIX #3184: Discarded node move changes are reflected correctly in the document tree
Scenario #2: Moved nodes do not just disappear after discarding the move change
mhsdesign
commented
Jun 23, 2024
| $workspace = $this->contentRepository->getWorkspaceFinder()->findOneByCurrentContentStreamId($eventInstance->getContentStreamId()); | ||
| if ($workspace === null) { | ||
| try { | ||
| $contentGraph = $this->contentRepository->getContentGraph($eventInstance->workspaceName); |
There was a problem hiding this comment.
using $eventInstance->workspaceName fixes most of the ui discard failures
|
So the ui is green with this but now the new |
6 tasks
|
As this is fixed now properly, I close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental possible alternative to #5155
Resolves: #5150
The discard tests of the neos ui will pass (#5150)
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions