-
-
Notifications
You must be signed in to change notification settings - Fork 925
[client] Add quick actions window #4717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
doromaraujo
wants to merge
26
commits into
netbirdio:main
Choose a base branch
from
doromaraujo:feature/quick-settings-show-popup-macos
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[client] Add quick actions window #4717
doromaraujo
wants to merge
26
commits into
netbirdio:main
from
doromaraujo:feature/quick-settings-show-popup-macos
+677
−528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now displays the NetBird logo and a single button with a round icon
This also updates fyne to v2.7.0
…ngs-show-popup-macos
To use its clipboard rather than the window's when showing the upload success dialog
Settings now accept a function callback
…doromaraujo/netbird into feature/quick-settings-show-popup-macos
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Describe your changes
Adds a window that will pop up when running NetBird on desktop after it is already running.
It sends a SIGUSR1 to a previously set up signal handler (platform-dependent) that will handle opening the window itself.
The window only contains the NetBird logo with a single button indicating the action to connect or disconnect.
When connected, the NetBird logo is colored, when disconnected, the logo is greyed out.
On connection change, the window closes on its own.
Issue ticket number and link
Stack
Checklist
Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__