-
-
Notifications
You must be signed in to change notification settings - Fork 927
[client] Add quick actions window #4717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
doromaraujo
wants to merge
33
commits into
netbirdio:main
Choose a base branch
from
doromaraujo:feature/quick-settings-show-popup-macos
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
5fadbeb
Open quick settings window if netbird-ui is already running
lixmal 07b378f
[client-ui] fix connection status comparison
doromaraujo 43ef5e4
[client-ui] modularize quick actions code
doromaraujo bd84332
[client-ui] add netbird-disconnected logo
doromaraujo 77cd871
[client-ui] change quickactions UI
doromaraujo a29a61b
[client-ui] add hint message to quick actions screen
doromaraujo 781844f
[client-ui] remove unnecessary default clause
doromaraujo 2cc84ce
[client-ui] remove commented code
doromaraujo fe94640
[client-ui] remove unused dependency
doromaraujo ecddf55
[client-ui] close quick actions on connection change
doromaraujo e2c0717
[client-ui] add function to get image from embed resources
doromaraujo 83577d1
[client] Return error when calling sendShowWindowSignal from Windows
doromaraujo 03cb2d9
[client-ui] Add commentary on empty OnTapped function for toggleConne…
doromaraujo 53e0466
[client-ui] Fix tests
doromaraujo 421c337
Merge remote-tracking branch 'upstream/main' into feature/quick-setti…
doromaraujo f666935
[client-ui] Add context to menuUpClick call
doromaraujo a1592a4
[client-ui] Pass serviceClient app as parameter
doromaraujo b791473
[client-ui] Replace for select with for range chan
doromaraujo b9130b9
[client-ui] Replace settings change listener channel
doromaraujo 3df0975
[client-ui] Add missing iconAboutDisconnected to icons_windows.go
doromaraujo 6f86725
[client] Add quick actions signal handler for Windows with named events
doromaraujo 632d0ab
Merge branch 'main' into feature/quick-settings-show-popup-macos
doromaraujo 1827df4
Merge branch 'feature/quick-settings-show-popup-macos' of github.com:…
doromaraujo fa88002
[client] Run go mod tidy
doromaraujo e10ebc0
[client] Remove line break
doromaraujo 3d55baa
[client] Log unexpected status in separate function
doromaraujo 0743511
[client-ui] Refactor quick actions window
doromaraujo 5bd40d0
[client-ui] use derived context from ServiceClient
doromaraujo 69cb1aa
[client] Update signal_windows log message
doromaraujo 27ff17d
Merge remote-tracking branch 'upstream/main' into feature/quick-setti…
doromaraujo d76212a
go mod tidy
doromaraujo 62e69d5
[client-ui] Add struct to pass fewer parameters
doromaraujo da6d4e0
[client] Add missing import
doromaraujo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restore the missing
setDefaultFontsimplementationclient.setDefaultFonts()is invoked here, but no definition is provided in any of the included build targets, and the static analysis/typecheck run already fails with “client.setDefaultFonts undefined”. The PR will not compile until the function is (re)introduced or this call is removed/guarded. Please add the missing implementation (with the appropriate build tags) or drop the call so the build succeeds.🧰 Tools
🪛 GitHub Check: JS / Lint
[failure] 124-124:
client.setDefaultFonts undefined (type *serviceClient has no field or method setDefaultFonts) (typecheck)