Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proper check napalm community driver packages #17

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: proper check napalm community driver packages #17

merged 1 commit into from
Dec 5, 2024

Conversation

leoparente
Copy link
Collaborator

No description provided.

@leoparente leoparente self-assigned this Dec 4, 2024
@github-actions github-actions bot added the python label Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
diode_napalm
   discovery.py35294%92–95
   parser.py55198%114
   version.py7186%14
diode_napalm/cli
   cli.py60198%164
TOTAL236598% 

Tests Skipped Failures Errors Time
37 0 💤 0 ❌ 0 🔥 2.625s ⏱️

mfiedorowicz
mfiedorowicz approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@leoparente leoparente merged commit 7821ec5 into develop Dec 5, 2024
4 checks passed
@leoparente leoparente deleted the fix/proper-discovery-napalm-community-drivers branch December 5, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

@natm natm Awaiting requested review from natm natm is a code owner

Assignees

@leoparente leoparente

Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leoparente @mfiedorowicz