Skip to content

fix: always add the url to json output #7738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: always add the url to json output #7738

wants to merge 4 commits into from

Conversation

@minivan
Copy link
Contributor

@minivan minivan commented Oct 23, 2025

When we removed the --prod as a requirement from the ntl build command, there's a check we missed. It's useful to see the url for deploys.

@minivan minivan requested a review from a team as a code owner October 23, 2025 15:18
@github-actions
Copy link

github-actions bot commented Oct 23, 2025 •
edited
Loading

📊 Benchmark results

Comparing with 882b3ee

  • Dependency count: 1,029 (no change)
  • Package size: 284 MB (no change)
  • Number of ts-expect-error directives: 379 (no change)

@minivan minivan enabled auto-merge (squash) October 23, 2025 15:59
serhalp
serhalp approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minivan minivan disabled auto-merge October 23, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhalp serhalp serhalp approved these changes

@VitaliyR VitaliyR VitaliyR approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@minivan @serhalp @VitaliyR