Skip to content

fix: always add the url to json output #7738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: always add the url to json output #7738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f471754
fix: always add the url to json output
minivan Oct 23, 2025
172f320
Merge branch 'main' into minivan/fix-astro-feedback
minivan Oct 23, 2025
a4997ac
Update tests/integration/commands/deploy/deploy.test.ts
minivan Oct 23, 2025
5fd6059
Merge branch 'main' into minivan/fix-astro-feedback
minivan Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/commands/deploy/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,9 +793,7 @@ const printResults = ({
logs: results.logsUrl,
function_logs: results.functionLogsUrl,
edge_function_logs: results.edgeFunctionLogsUrl,
}
if (deployToProduction) {
jsonData.url = results.siteUrl
url: results.siteUrl,
}

if (uploadSourceZip) {
Expand Down
4 changes: 3 additions & 1 deletion tests/integration/commands/deploy/deploy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
logs: string
function_logs: string
edge_function_logs: string
url: string
}

const validateDeploy = async ({
Expand All @@ -76,9 +77,10 @@
expect(deploy.logs).toBeTruthy()
expect(deploy.function_logs).toBeTruthy()
expect(deploy.edge_function_logs).toBeTruthy()
expect(deploy.url).toBeTruthy()
expect(deploy.site_name).toEqual(siteName)

await validateContent({ siteUrl: deploy.deploy_url, path: '', content })
await validateContent({ siteUrl: deploy.deploy_url, url: deploy.siteUrl, path: '', content })

Check failure on line 83 in tests/integration/commands/deploy/deploy.test.ts

View workflow job for this annotation

GitHub Actions / typecheck 

Property 'siteUrl' does not exist on type 'Deploy'.

Check failure on line 83 in tests/integration/commands/deploy/deploy.test.ts

View workflow job for this annotation

GitHub Actions / typecheck 

Object literal may only specify known properties, and 'url' does not exist in type '{ content?: string | undefined; headers?: Record<string, string> | undefined; path: string; pathname?: string | undefined; siteUrl: string; }'.
}

const context: { account: unknown; siteId: string } = {
Expand Down Expand Up @@ -505,7 +507,7 @@
})
})

test('should include stdout and stderr when build fails with --json --verbose options', async (t) => {

Check failure on line 510 in tests/integration/commands/deploy/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Integration (ubuntu-latest, 22, 4/4)

tests/integration/commands/deploy/deploy.test.ts > commands/deploy > should include stdout and stderr when build fails with --json --verbose options 

Error: Test timed out in 90000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
 ❯ tests/integration/commands/deploy/deploy.test.ts:510:3

Check failure on line 510 in tests/integration/commands/deploy/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Integration (ubuntu-latest, 22, 4/4)

tests/integration/commands/deploy/deploy.test.ts > commands/deploy > should include stdout and stderr when build fails with --json --verbose options 

Error: Test timed out in 90000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
 ❯ tests/integration/commands/deploy/deploy.test.ts:510:3

Check failure on line 510 in tests/integration/commands/deploy/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Integration (ubuntu-latest, 22, 4/4)

tests/integration/commands/deploy/deploy.test.ts > commands/deploy > should include stdout and stderr when build fails with --json --verbose options 

Error: Test timed out in 90000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
 ❯ tests/integration/commands/deploy/deploy.test.ts:510:3
await withSiteBuilder(t, async (builder) => {
builder
.withContentFile({
Expand Down
Loading