Nit: better text asking for copying #136
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
=======================================
Coverage 22.66% 22.66%
=======================================
Files 10 10
Lines 1337 1337
=======================================
Hits 303 303
Misses 1015 1015
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. |
It's conventional and more user-friendly to tell which prompts are accepted (even if more than that would actually work), so user isn't worried about typing wrong things Also, no space before question mark in English Update scripts/functions.sh
| @@ -251,7 +251,7 @@ function cleanup { | |||
| copyOutput | |||
| elif [ "$copy" = "prompt" ]; then | |||
| while true; do | |||
| read -rp "Copy the capture output locally ?" yn | |||
| read -rp "Copy the capture output locally? [yes/no] " yn | |||
There was a problem hiding this comment.
Should we also manage the fully written word "yes" and "no" then ?
There was a problem hiding this comment.
If I'm correct, full yes/no already works (anything starting with a y or with a n works)
I wrote that based on the text below that already says:
"*) echo "Please answer yes or no." ;;"
There was a problem hiding this comment.
Indeed it already works 🆗
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's conventional and more user-friendly to tell which answers are accepted (even if more than that would actually work), so user isn't worried about typing wrong things
Also, no space before question mark in English