Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: better text asking for copying #136

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Nit: better text asking for copying #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/functions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ function cleanup {
copyOutput
elif [ "$copy" = "prompt" ]; then
while true; do
read -rp "Copy the capture output locally ?" yn
read -rp "Copy the capture output locally? [yes/no] " yn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also manage the fully written word "yes" and "no" then ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm correct, full yes/no already works (anything starting with a y or with a n works)
I wrote that based on the text below that already says:
"*) echo "Please answer yes or no." ;;"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it already works 🆗

case $yn in
[Yy]*)
copyOutput
Expand Down
Loading