NETOBSERV-1910: Add packet drop filtering API #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:bc80d3d make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-bc80d3dOr as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-bc80d3d
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
==========================================
- Coverage 66.55% 66.38% -0.18%
==========================================
Files 74 74
Lines 8693 8705 +12
==========================================
- Hits 5786 5779 -7
- Misses 2499 2515 +16
- Partials 408 411 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jotak
reviewed
Sep 30, 2024
| @@ -249,6 +249,10 @@ type EBPFFlowFilter struct { | |||
| // ICMPCode defines the ICMP code to filter flows by. | |||
| // +optional | |||
| ICMPCode *int `json:"icmpCode,omitempty"` | |||
|
|
|||
| // `pktDrop`, to filter flows with packet drops | |||
There was a problem hiding this comment.
Suggested change
| // `pktDrop`, to filter flows with packet drops | |
| // `pktDrops`, to filter flows with packet drops |
jotak
reviewed
Sep 30, 2024
| @@ -273,6 +273,10 @@ type EBPFFlowFilter struct { | |||
| // `icmpType`, for ICMP traffic, defines the ICMP type to filter flows by. | |||
| // +optional | |||
| ICMPType *int `json:"icmpType,omitempty"` | |||
|
|
|||
| // `pktDrop`, to filter flows with packet drops | |||
There was a problem hiding this comment.
Suggested change
| // `pktDrop`, to filter flows with packet drops | |
| // `pktDrops`, to filter flows with packet drops |
Signed-off-by: Mohamed Mahmoud <[email protected]>
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:5e0b266 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-5e0b266Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-5e0b266
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
|
/test all |
jotak
approved these changes
Oct 8, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
msherif1234
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add pkt drop filtering capability
Dependencies
netobserv/netobserv-ebpf-agent#419
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.