Fix Docker auths script to use environment variable values and handle… #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… image URI parsing errors
taddeusb90
approved these changes
Jan 30, 2025
YevheniiSemendiak
approved these changes
Jan 30, 2025
for more information, see https://pre-commit.ci
…t parameterization
for more information, see https://pre-commit.ci
YevheniiSemendiak
approved these changes
Feb 1, 2025
YevheniiSemendiak
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains fixes in the remote image building, specially when trying to push to an external registry.
Fixes:
apolo_extras/assets/merge_docker_auths.sh: Fixed an issue that happened when the registry env var contained formatted json and our script would only get the first line of that jsonapolo_extras/image.py: If it is not possible to convert aimage_urito a platform image uri it may be because the user is trying to push to an external registry. So we do not stop the execution in this caseapolo-cliTest configuration enhancements:
tests/unit/image/conftest.py: Added a mockAppsConfigused in Apolo SDK's latest version