Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker auths script to use environment variable values and handle… #670

Merged
merged 23 commits into from
Feb 11, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
82a6bf7
Fix Docker auths script to use environment variable values and handle…
jordyantunes Jan 30, 2025
4e57d38
Bump apolo-cli and apolo-sdk to version 24.12.3
jordyantunes Jan 30, 2025
5acc38a
Bump apolo-cli to version 24.12.3 in setup.py
jordyantunes Jan 30, 2025
d7b00ec
Update CI workflow to use NEURO_TOKEN for Apolo login
jordyantunes Jan 30, 2025
20de25f
Fix CI workflow to use APOLO_TOKEN for Apolo login instead of NEURO_T…
jordyantunes Jan 30, 2025
356ac79
Update CI workflow to use fixed NEURO_STAGING_URL for Apolo integration
jordyantunes Jan 30, 2025
7aec1b3
Update CI workflow to use APOLO_DEV_TOKEN for Apolo login
jordyantunes Jan 30, 2025
5db30e2
Update CI workflow to use CLIENT_TEST_E2E_USER_NAME for Apolo token
jordyantunes Jan 30, 2025
8ee4eed
Update CI workflow to use CLIENT_TEST_E2E_USER_NAME for Apolo token
jordyantunes Jan 30, 2025
9900612
Update CI workflow to change APOLO_PROJECT from e2e-tests to apolo-ex…
jordyantunes Jan 30, 2025
1bb5ce7
hack to skip lazyfixture bug
jordyantunes Jan 30, 2025
62f55e3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 30, 2025
9d7ef0a
fix linting error
jordyantunes Jan 30, 2025
5f1c5c6
Remove pytest-lazy-fixture dependency and refactor tests to use direc…
jordyantunes Jan 30, 2025
af88042
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 30, 2025
432186e
Fix linting issues
jordyantunes Jan 30, 2025
232c5f3
Update GCS paths and secret references in test configuration
jordyantunes Jan 31, 2025
3bfeead
Add prepare-e2e-test target and script for E2E test setup
jordyantunes Jan 31, 2025
5f3f38b
fix linting error
jordyantunes Jan 31, 2025
e5ca489
Update GCP credentials reference in CI workflow
jordyantunes Jan 31, 2025
289e3e5
Add prepare volumes and disks step to CI workflow and update Makefile…
jordyantunes Jan 31, 2025
ed1c410
Move prepare volumes and disks step to the preparetests CI workflow
jordyantunes Jan 31, 2025
ead6eea
Remove conditional check for 'master' branch in Prepare volumes and d…
jordyantunes Jan 31, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apolo_extras/assets/merge_docker_auths.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ then
fi
for auth in ${extra_auths}; do
key="${auth%%=*}"
value="${auth#*=}"
value=$(printenv $key)
if [ -f "${value}" ]; then
# ENV var points to the file
jq < ${value} > /dev/null 2>&1 && res=`echo $res | cat - ${value} | jq -sc 'reduce .[] as $item ({}; . * $item)'`
Expand Down
7 changes: 6 additions & 1 deletion apolo_extras/image.py
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,12 @@ async def _build_image(
client, image_uri_str, project_name, scheme="image"
)
async with get_platform_client(cluster=cluster) as client:
image_uri = client.parse.str_to_uri(image_uri_str, project_name=project_name)
try:
image_uri = str(
client.parse.str_to_uri(image_uri_str, project_name=project_name)
)
except ValueError:
image_uri = image_uri_str
image = await _parse_platform_image(str(image_uri))
context_uri = client.parse.str_to_uri(
context,
Expand Down
1 change: 1 addition & 0 deletions tests/unit/image/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ def _get_mock_clusters() -> t.Dict[str, apolo_sdk.Cluster]:
resource_pools={},
presets=_get_mock_presets(),
orgs=[],
apps=apolo_sdk.AppsConfig(),
YevheniiSemendiak marked this conversation as resolved.
Show resolved Hide resolved
),
}

Expand Down
Loading