Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fusion of all configuration files in configuration_config.yml #97

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

AcastaPaloma
Copy link
Collaborator

@AcastaPaloma AcastaPaloma commented Nov 2, 2024

These are the current configuration files for the module upon installation:

classification_config.yml
general_config.yml
keyboard_shortcuts_config.yml
label_config.yml

Pull request includes deletion of four mentioned configuration files and addition of configuration_config.yml which includes their contents. Includes simplification of main file.

#68 states that these files are too confusing and should be regrouped into a single configuration file modifiable by the Configuration Window upon startup of the module.

Pull request should be tested to see if any errors come from not being able to access the new configuration_config.yml

There is a known bug in this pull request that opens up two SlicerCARTConfigurationSetupWindows after Configure segmentation... is clicked.
See screenshots for more information regarding the reproduction of this bug:

First step
image

Second step
image

Add labels, toggle the timer checkbox, etc. **Then click on Apply**

Third step
image

Two configuration windows appear for no apparent reason. The issue is not reproducible when Configure classification... is clicked on step 1 instead of Configure segmentation...

@AcastaPaloma AcastaPaloma changed the title fusion of all configuration files in configuration_config.csv fusion of all configuration files in configuration_config.yml Nov 2, 2024
@AcastaPaloma
Copy link
Collaborator Author

I have a feeling that this problem is with Qt and Slicer itself. The logic itself to handle window opening and closing is often not robust on my side - windows open & load slowly, windows will close and open inconsistently, etc. Maybe an issue with the fact that I'm using Windows?

@AcastaPaloma
Copy link
Collaborator Author

Issue fixed. There were two lines of code connecting to the opening of the ConfigurationSetupWindow. Code fragmentation is a top priority as this issue could have been resolved much easier with easier legibility.

Copy link
Member

@maxradx maxradx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue 35. Multiple configuration files merged into 1 configuration file. Works fine. Thanks to Kuan.

@maxradx maxradx merged commit d2714db into main Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuration of whether all segments are saved to a single file or to separate files (.nii.gz)
2 participants