-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rosebud Ship #309
Merged
Merged
Rosebud Ship #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(it wasnt.)
Looking at the ships and files as they are right now I don't see issues. |
mostly based on having more exped experience. added some more unique job positions (CE, chemist, paramed/doctor) and their relevant spawnpoints/lockers. also made solars identical between models. gave chem crates so you don't just have to buy all the chems outright (bringing in line with crescent.) upped the prices a bit, gave captain an antique because other similar ships have it, (and this ship doesn't really have any kind of armory). costs recalculated. moved a few other things around.
finally stopped being lazy
are we ready for one more (hopefully final!) review? I will probably load it up and check tonight any way |
Cheackraze
approved these changes
Sep 28, 2023
FrontierATC
added a commit
that referenced
this pull request
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds the Rosebuds MKI and MKII.
The MKI is a luxurious, medium-sized salvage and expedition ship intended for small, efficient crews. It was created with the intention of being an upgrade of sorts to the Prospector - it has a similar layout and purpose, just with everything ramped up to 11. More conveyors, more space, with a nice centralized salvage bay, all running on solar power!
Compared to the Prospector, Rosebud's salvaging area is more symmetrical, has a medbay and chemistry room, a simple atmos setup, a bridge/captain's room, an engineering & break room, a locker & dorm room for employees.
The MKII is an upgrade that mostly just adds a larger docking area with a full AME setup. She's expedition-capable as a result! Otherwise, the MKI and MKII are nigh-identical. After a little testing, the MKII seems to need three RTGs to replace its AME, so its definitely necessary despite the solars.
The Rosebud notably lacks R&D, meaning it hopefully shouldn't step on the toes of any salvage/r&d mix vessels. It also has functioning disposals, making it the best ship in the galaxy. You're welcome.
Media
MKI
MKII
Tested everything (atmos, expeds, power) and it seems to work fine.
Changelog
🆑