Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rosebud Ship #309

Merged
merged 22 commits into from
Sep 28, 2023
Merged

Rosebud Ship #309

merged 22 commits into from
Sep 28, 2023

Conversation

rosieposieeee
Copy link
Contributor

@rosieposieeee rosieposieeee commented Sep 13, 2023

About the PR

Adds the Rosebuds MKI and MKII.

The MKI is a luxurious, medium-sized salvage and expedition ship intended for small, efficient crews. It was created with the intention of being an upgrade of sorts to the Prospector - it has a similar layout and purpose, just with everything ramped up to 11. More conveyors, more space, with a nice centralized salvage bay, all running on solar power!

Compared to the Prospector, Rosebud's salvaging area is more symmetrical, has a medbay and chemistry room, a simple atmos setup, a bridge/captain's room, an engineering & break room, a locker & dorm room for employees.

The MKII is an upgrade that mostly just adds a larger docking area with a full AME setup. She's expedition-capable as a result! Otherwise, the MKI and MKII are nigh-identical. After a little testing, the MKII seems to need three RTGs to replace its AME, so its definitely necessary despite the solars.

The Rosebud notably lacks R&D, meaning it hopefully shouldn't step on the toes of any salvage/r&d mix vessels. It also has functioning disposals, making it the best ship in the galaxy. You're welcome.

Media

MKI
Content Client_W5ZXtW7azI
Content Client_3dCO10U5rz

MKII
Content Client_gcqdI6Huxg
Content Client_Ma7M5Uvooo

Tested everything (atmos, expeds, power) and it seems to work fine.

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • add: Added the Rosebud MKI and Rosebud MKII, medium-sized luxury salvaging vessels.

@dvir001
Copy link
Contributor

dvir001 commented Sep 17, 2023

Looking at the ships and files as they are right now I don't see issues.
It seem that the files do have only lowercase in the names and GitHub showing the one before as the titles, nothing to changes if that's the case with the files names.

rosieposieeee and others added 4 commits September 19, 2023 14:07
mostly based on having more exped experience. added some more unique job positions (CE, chemist, paramed/doctor) and their relevant spawnpoints/lockers. also made solars identical between models. gave chem crates so you don't just have to buy all the chems outright (bringing in line with crescent.) upped the prices a bit, gave captain an antique because other similar ships have it, (and this ship doesn't really have any kind of armory). costs recalculated. moved a few other things around.
finally stopped being lazy
@Cheackraze
Copy link
Member

almost ready! Just some very minor changes id like to see first.
rosebud mk1 final changes
for the mkI, just add some grilles under these windows so we match everywhere and its good to go (i'll still double check loot fill)

rosebud mk2 final changes
same for the mkII however, these diagonal arms off the sides here look kind of not great. Long stretches of diagonal walls like this look bad, and they dont occlude properly, so these will appear like invisible walls in game and just look overall bad. I suggest either thickening these walls up, or just slightly rediesigning these so that they might not stick so far out or just arent such thin diagonal walls. The other thing was the 2 doors being corner to eachother but if you redesign those arms a touch then it will probably work itself out.

Overall great, just a few minor tweaks and we can get this in by the weekend!

@Cheackraze
Copy link
Member

are we ready for one more (hopefully final!) review? I will probably load it up and check tonight any way

@Cheackraze Cheackraze merged commit ae5bcd6 into new-frontiers-14:master Sep 28, 2023
13 of 14 checks passed
FrontierATC added a commit that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants