NFSD Outpost (New) - Split NFSD away from Frontier Outpost

[TsjipTsjip]

About the PR

Adds the NFSD outpost, a new POI which serves as the base of operations for the NFSD.

Downsizes NFSD on Frontier Outpost, replacing it with:

• Station guard holding cell
• Frontier staff break room (service locked)
• Dedicated stage for the musician
• More maints

Media

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Initmapped:

Mapping view:

NFSD downsizing on frontier outpost:

Bridge updates with new vault, also janitor locker:

Simplified waste line:

Breaking changes

Changelog

🆑

• add: Added the NFSD outpost, a new base of operations for the Sheriff and their subordinates!

[TsjipTsjip]

Okay so this is where we are at right now:

• Spawning works
• Station is nearly done (Needs decalling and docks need a little expanding)

This is what we still need:

• Split bank account
• OR a joint bank account with frontier
• Security cargo request computer
• Security cargo teleporter
• Security cargo sales console
• Station records are not station recordsering. Can't open latejoin slots.

[Cheackraze]

So theres a specific bugs with station records console in that, if there are 0 records for the station, it doesnt show the late join sliders. This is a result of the late join menu portion being a child and therefore inside of the actual technical 'records' entries, but the whole UI itself just doesnt render that bit of UI if there are no records to begin with.

It could be fixed, or you could give it a quick test by spawning in to an automatic late join opened slot.

[TsjipTsjip]

Ready for reviiieeewwwww!!!

This is what we have:

• Spawning works
• Station is in a final touches state

This is what we still need:

• Split bank account (Future PR)
• OR a joint bank account with frontier (Future PR)
• Security cargo things (Future PR)
• Downsize NFSD on Frontier Outpost (Future PR)
• Bus (Future PR)

Potential issues:

• If there is no sheriff, no NFSD can be hired through opening slots for them due to the above station records bug. (Minor, regular in-character hiring is still possible.)

[MagnusCrowe]

No meteor shielding grilles?

[TsjipTsjip]

No meteor shielding grilles?

Is this necessary? Frontier Outpost does not have these either, neither do most of the POI's.

[TsjipTsjip]

We should be up-to-date with master on this branch again. NFSD on frontier outpost has been downsized already in this PR, along with wrapping up a lot more QoL things that needed to be done on Frontier. (Cargo conveyors come to mind.)

[Cheackraze]

No meteor shielding grilles?

Is this necessary? Frontier Outpost does not have these either, neither do most of the POI's.

Most of the POI have all surfaces reserved for docking space is why. I tried my best to add asteroid catchers to frontier where possible but sometimes it's not. Think if it this way too, it's an opportunity to electrify them with lv/mv for an added layer of security. I would say overall it looks good, and we will likely need to just merge and plates it to figure out what does and doesn't work on it.

I will want to load this up in game and give it a proper test. I have a kind of busy weekend ahead of me but I'm aiming for Monday at the very latest to have this officially and fully reviewed.

[Cheackraze]

I would say asteroid catchers aren't really necessary, however it would definitely make it look and feel better

[TsjipTsjip]

I will look into asteroid shielding solutions for this POI, as I do indeed have significant non-docking surface area. Thanks for the feedback, and take your time. Willing to actively maintain this POI to bring it up to scratch during play testing.

[TsjipTsjip]

Asteroid shields are in place and should be (relatively) random every round via the random spawners. I tried my best to make it look "janky", and I do believe this looks better on mass scanners as well.

[TsjipTsjip]

Together with @dvir001 we found out how to anchor all POI's in space so they can't be moved. (Based on #40 )

This PR, while technically out-of-scope, anchors all POI's and Frontier outpost to a standard 99999 both linear and angular damping.

[Cheackraze]

maps themselves look fantastic, im excited to see how this plays, just a few very minor tweaks and its good to go

[Cheackraze]

I think we need to not parent off from outposts, and instead just make this its own base class. Reason being, we need to make sure that Borg laws dont allow for some silly 'rules' while aboard an official NT outpost. Aside from that, it would only inherit 'cargo' as a component, and we are likely going to modify this some more later on to get seperate cargo accounts working.

[TsjipTsjip]

Not sure if this is fully addressed in 12e943e .

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.