Errors Inbox transaction tracing updates #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fallwith
commented
Mar 22, 2024
fallwith
commented
- The transaction's guid should be present for both the ErrorTrace and TransactionError types
- Be sure (tests added, no lib code altered) that distributed tracing isn't required for the transaction guid to be populated
- The transaction's guid should be present for both the ErrorTrace and TransactionError types - Be sure (tests added, no lib code altered) that distributed tracing isn't required for the transaction guid to be populated
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
SimpleCov Report
|
fallwith
commented
Mar 22, 2024
| SPAN_ID_KEY = 'spanId'.freeze | ||
| PRIORITY_KEY = 'priority' | ||
| SPAN_ID_KEY = 'spanId' | ||
| GUID_KEY = 'guid' |
There was a problem hiding this comment.
The redundant String#freeze calls were all removed given that we're using the special frozen_string_literal comment.
The existing CAT specific values had their constants renamed with a CAT_ prefix.
A new GUID_KEY constant was added to hold the transaction id when one is known.
kaylareopelle
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.