Skip to content

Conversation

CreatorOfBiontium
Copy link
Contributor

This PR focuses on fixing image alignment.
The alignment works when composing and sending emails, but in SignatureSettings.vue it doesn’t display the aligment menu (neither does the button descriptions). That part still needs work.

Additionally:

  • When saving a draft or sending a message, CKEditor ignores the added alignment classes.
  • The same issue might require adjustments in the email display view.
  • CKEditor also ignores image resizing — images are always scaled to the maximum width.

@GretaD
Copy link
Contributor

GretaD commented Sep 12, 2025

Hi,

thanks a lot for your PR. We will have a look asap.

@CreatorOfBiontium
Copy link
Contributor Author

CreatorOfBiontium commented Sep 12, 2025

Just a claricifation:

"CKEditor also ignores image resizing — images are always scaled to the maximum width."

=> it doesn't display size properly when reopening a draft

CreatorOfBiontium and others added 2 commits September 12, 2025 16:30
This code is from the original PR that I split into two — it contained both dark mode fixes and image alignment, so I had to separate them.
It should work, but it still needs a bit more work — especially regarding the signature settings.

Signed-off-by: Tobiáš Vašťák <[email protected]>
Signed-off-by: Biontium <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Biontium <[email protected]>
CreatorOfBiontium and others added 2 commits September 12, 2025 16:51
Fix minor lint issues (extra semicolons, trailing spaces, commas, etc.).
Import issues with CKEditor plugins are still pending and will be handled separately.

Signed-off-by: Biontium <[email protected]>
@kesselb kesselb self-assigned this Sep 12, 2025
@CreatorOfBiontium
Copy link
Contributor Author

What do you suggest here - the ckeditor doesn't have the plugins for image aligement avalible when running lint. How do we include them?

@kesselb
Copy link
Contributor

kesselb commented Sep 14, 2025

Thanks for your pr 👍

I think we should evaluate to implement it as ckeditor plugin. I will have a closer look when time allows.

How do we include them?

Commit the changes to package.json and package-lock.json.

Refactored so it works with lint.

Signed-off-by: Biontium <[email protected]>
@CreatorOfBiontium
Copy link
Contributor Author

Adding to package.json not needed – just adjusted imports to satisfy lint and it works :o

@CreatorOfBiontium
Copy link
Contributor Author

Nevermind, it doesn't throw an error in lint, but doesn't work either :( I pushed it there thinking it would import just ok, but I fully tested it just now and it breaks the whole toolbar, as it just doesn't show. Any idea? I might try somethng tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants