-
Notifications
You must be signed in to change notification settings - Fork 280
Fix image alignment in email composer #11666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix image alignment in email composer #11666
Conversation
Hi, thanks a lot for your PR. We will have a look asap. |
Just a claricifation: "CKEditor also ignores image resizing — images are always scaled to the maximum width." => it doesn't display size properly when reopening a draft |
8311b9c
to
9e66bb7
Compare
This code is from the original PR that I split into two — it contained both dark mode fixes and image alignment, so I had to separate them. It should work, but it still needs a bit more work — especially regarding the signature settings. Signed-off-by: Tobiáš Vašťák <[email protected]> Signed-off-by: Biontium <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Biontium <[email protected]>
d4b6635
to
27445d5
Compare
Fix minor lint issues (extra semicolons, trailing spaces, commas, etc.). Import issues with CKEditor plugins are still pending and will be handled separately. Signed-off-by: Biontium <[email protected]>
What do you suggest here - the ckeditor doesn't have the plugins for image aligement avalible when running lint. How do we include them? |
Thanks for your pr 👍 I think we should evaluate to implement it as ckeditor plugin. I will have a closer look when time allows.
Commit the changes to package.json and package-lock.json. |
Refactored so it works with lint. Signed-off-by: Biontium <[email protected]>
Adding to package.json not needed – just adjusted imports to satisfy lint and it works :o |
Nevermind, it doesn't throw an error in lint, but doesn't work either :( I pushed it there thinking it would import just ok, but I fully tested it just now and it breaks the whole toolbar, as it just doesn't show. Any idea? I might try somethng tomorrow. |
This PR focuses on fixing image alignment.
The alignment works when composing and sending emails, but in SignatureSettings.vue it doesn’t display the aligment menu (neither does the button descriptions). That part still needs work.
Additionally: