Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: change parameter style to avoid_final_parameters #1325

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

Leptopoda
Copy link
Member

fixes: #1245

This does not migrate all of our packages and I don't see the need to do this any time soon.
For the bigger ones like dynamite or the framework we could also just keep it for ever.

@provokateurin
Copy link
Member

I'd prefer a single style for all packages. Either remove them everywhere or keep them everywhere.

@Leptopoda
Copy link
Member Author

Can we still do this incrementally?

@provokateurin
Copy link
Member

Sure

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only change the rules for the packages that you are migrating in this PR instead of changing the default and overriding it in all other packages.

packages/nextcloud/build.yaml Outdated Show resolved Hide resolved
@Leptopoda
Copy link
Member Author

Please only change the rules for the packages that you are migrating in this PR instead of changing the default and overriding it in all other packages.

I disagree. While I will try to tackle this in the coming days the individual migrations (especially the framework) will take some time.

If we where to introduce a new package in that time it should automatically have the new rules.

@provokateurin
Copy link
Member

Ok I get that point. Then please add a TODO comment everywhere where the rules are manually changed.

@Leptopoda Leptopoda force-pushed the style/change-lint-rules branch from cba9fee to 1ecb4d8 Compare December 20, 2023 10:38
@Leptopoda Leptopoda enabled auto-merge December 20, 2023 10:58
@Leptopoda Leptopoda merged commit ebd1757 into main Dec 20, 2023
8 checks passed
@Leptopoda Leptopoda deleted the style/change-lint-rules branch December 20, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discuss used lint rules
2 participants