Refactor NomadService to rely on Builder classes #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Maybe the JobBuilder can receive a Task and it creates the job/group/task from it basically what the service is doing right now but in the builder, so the service only "call the builder 1 time" and receive a Job spec |
abhi18av
force-pushed
the
feature/builder-classes
branch
from
0157d7d
to
b6eaff0
Compare
jagedn
approved these changes
Sep 17, 2024
|
Thanks for the review Jorge! Sure, I'll migrate the tests and finalize the PR soon :) |
|
and them .... create a new -edge version 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses comments by @jagedn in #87
Ideally, we keep the interface for NomadService minimal.