Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: post release, wait 10min before docker update #1158

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

corneliusroemer
Copy link
Member

Mitigates nextstrain/docker-base#128

It seems to take a few minutes for Pypi to return the newest release. So we should delay triggering the automatic docker build. 10min seems like a reasonable wait time. The update happened around 2min when we last did the release.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 68.17% // Head: 68.17% // No change to project coverage 👍

Coverage data is based on head (27e4692) compared to base (eef2a05).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1158   +/-   ##
=======================================
  Coverage   68.17%   68.17%           
=======================================
  Files          63       63           
  Lines        6752     6752           
  Branches     1654     1654           
=======================================
  Hits         4603     4603           
  Misses       1841     1841           
  Partials      308      308           
Impacted Files Coverage Δ
augur/__version__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @corneliusroemer, this is an easy and simple stop-gap for now.

Maybe in the longer term we could just check the PyPI endpoint here. Then we only run the docker-base workflow if the returned version is equal to github.event.inputs.version.
That may require us to query the PyPI endpoint a couple times before updating docker-base. I'm not sure if there's GH Action syntax for re-running a step/job multiple times 🤔

@corneliusroemer
Copy link
Member Author

Maybe in the longer term we could just check the PyPI endpoint here. Then we only run the docker-base workflow if the returned version is equal to github.event.inputs.version.
That may require us to query the PyPI endpoint a couple times before updating docker-base. I'm not sure if there's GH Action syntax for re-running a step/job multiple times 🤔

We could just have a bash loop that sleeps while the versions aren't equal, then once they are equal trigger the workflow dispatch

@corneliusroemer corneliusroemer merged commit d860afe into master Feb 23, 2023
@corneliusroemer corneliusroemer deleted the delay-docker-update branch February 23, 2023 04:23
@victorlin
Copy link
Member

Seems to be a reasonable short-term solution, but I'd move away from using the PyPI endpoint before working around it even more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants